mozempk/insta-recipe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore(RECIPE-0004): complete iteration 1 — fix TypeScript Timer type errors

Browse Source 
- Fixed NodeJS.Timer → NodeJS.Timeout in scheduler.ts line 13
- Fixed NodeJS.Timer[] → NodeJS.Timeout[] in fixtures.ts line 151
- Resolves TypeScript compile errors from iteration 0 review
- All 260 tests passing, build succeeds with no errors
This commit is contained in:
Giancarmine Salucci
2026-02-17 03:08:21 +01:00
parent e749763911
commit 67ab3c02d7
41 changed files with 3872 additions and 274 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/lib/server/api/errorHandler.ts
View File

@@ -15,6 +15,7 @@
import { json } from '@sveltejs/kit';
import { ValidationError, NotFoundError, ConflictError } from './errors';
import { logError } from '../utils/logger';
/**
* Handle API errors and convert to appropriate HTTP responses
@@ -24,7 +25,7 @@ import { ValidationError, NotFoundError, ConflictError } from './errors';
*/
export function handleApiError(error: unknown): Response {
// Log all errors for debugging
console.error('[API Error]', error);
logError('[API Error]', error);
// Handle known error types with specific status codes
if (error instanceof ValidationError) {

1
src/lib/server/browser.ts
View File

@@ -17,7 +17,6 @@ export async function initializeBrowser(): Promise<Browser> {
console.log('Initializing Playwright browser...');
browser = await chromium.launch({
executablePath: '/usr/bin/chromium-browser',
headless: true,
args: [
'--disable-blink-features=AutomationControlled',

28
src/lib/server/extraction.ts
View File

@@ -1,4 +1,5 @@
import { createBrowserContext } from './browser';
import { logError } from './utils/logger';
import fs from 'fs';
import path from 'path';
import type { Page, BrowserContext } from 'playwright';
@@ -151,7 +152,7 @@ async function withRetry<T>(
if (attempt < config.maxAttempts) {
const message = `Attempt ${attempt}/${config.maxAttempts} failed. Retrying in ${delay}ms...`;
console.warn(`[Retry] ${message}`, error);
logError(`[Retry] ${message}`, error);
onProgress?.({
type: 'retry',
@@ -228,7 +229,7 @@ async function extractFromEmbeddedJSON(
return { ...result, thumbnail };
}
} catch (e) {
console.warn('Failed to parse _sharedData:', e);
logError('[Extractor] Failed to parse _sharedData', e);
}
}
@@ -243,14 +244,14 @@ async function extractFromEmbeddedJSON(
return { ...result, thumbnail };
}
} catch (e) {
console.warn('Failed to parse __additionalDataLoaded:', e);
logError('[Extractor] Failed to parse __additionalDataLoaded', e);
}
}
}
return null;
} catch (error) {
console.warn('Failed to extract from embedded JSON:', error);
logError('[Extractor] Failed to extract from embedded JSON', error);
return null;
}
}
@@ -284,7 +285,7 @@ function parseInstagramData(data: any): Omit<ExtractedContent, 'thumbnail'> | nu
bodyText: cleanText(bodyText)
};
} catch (error) {
console.warn('Failed to parse Instagram data structure:', error);
logError('[Extractor] Failed to parse Instagram data structure', error);
return null;
}
}
@@ -308,7 +309,7 @@ function extractFromAlternativeStructure(items: any): Omit<ExtractedContent, 'th
return null;
} catch (error) {
console.warn('Failed to parse alternative structure:', error);
logError('[Extractor] Failed to parse alternative structure', error);
return null;
}
}
@@ -356,7 +357,7 @@ async function extractFromDOM(
thumbnail
};
} catch (error) {
console.warn('Failed to extract from DOM:', error);
logError('[Extractor] Failed to extract from DOM', error);
return null;
}
}
@@ -413,7 +414,7 @@ async function extractViaGraphQL(
thumbnail: null // GraphQL doesn't easily provide thumbnail, would need page context
};
} catch (error) {
console.error('GraphQL extraction failed:', error);
logError('[Extractor] GraphQL extraction failed', error);
return null;
}
}
@@ -421,6 +422,7 @@ async function extractViaGraphQL(
/**
* Strategy 4: Legacy extraction method (fallback)
*/
async function extractCleanTextLegacy(page: Page): Promise<string> {
let text = (await page.evaluate(() => document.body.innerText))
.replace(/^(?:.*\n){6}/, '') // Remove first 6 lines
@@ -500,7 +502,7 @@ async function extractWithStrategies(
};
}
} catch (error) {
console.warn(`[Extractor] Method ${strategy.name} failed:`, error);
logError(`[Extractor] Method ${strategy.name} failed`, error);
// Continue to next strategy
}
}
@@ -727,7 +729,7 @@ async function fetchImageAsBase64(
});
}
} else {
console.error('[Thumbnail] Failed to fetch image:', e);
logError('[Thumbnail] Failed to fetch image', e);
}
return null;
}
@@ -792,7 +794,7 @@ async function extractThumbnailStealth(
}
}
} catch (e) {
console.log('[Thumbnail] Meta tag method failed:', e);
logError('[Thumbnail] Meta tag method failed', e);
}
// Method 2: Try video poster attribute
@@ -814,7 +816,7 @@ async function extractThumbnailStealth(
}
}
} catch (e) {
console.log('[Thumbnail] Video poster method failed:', e);
logError('[Thumbnail] Video poster method failed', e);
}
// Method 3: Try Instagram window data structures
@@ -853,7 +855,7 @@ async function extractThumbnailStealth(
}
}
} catch (e) {
console.log('[Thumbnail] Instagram data method failed:', e);
logError('[Thumbnail] Instagram data method failed', e);
}
// Method 4: Screenshot fallback (existing method)

5
src/lib/server/llm.ts
View File

@@ -1,5 +1,6 @@
import OpenAI from 'openai';
import { env } from '$env/dynamic/private';
import { logError } from './utils/logger';
export const createLLM = () => {
// Detect if we are using Ollama or OpenAI based on URL
@@ -37,7 +38,7 @@ export async function checkLLMHealth(): Promise<boolean> {
console.log('[LLM] Health check passed');
return true;
} catch (e) {
console.error('[LLM] Health check failed:', e);
logError('[LLM] Health check failed', e);
return false;
}
}
@@ -71,7 +72,7 @@ export async function checkModelAvailability(
};
}
} catch (e) {
console.error('[LLM] Model availability check failed:', e);
logError('[LLM] Model availability check failed', e);
return {
available: false,
message: `Failed to check model availability: ${(e as Error).message}`

60
src/lib/server/notifications/PushNotificationService.ts
View File

@@ -5,6 +5,7 @@
* when users are not actively viewing the application.
*/
import webpush from 'web-push';
import { queueConfig } from '../queue/config';
interface PushSubscription {
@@ -32,6 +33,15 @@ class PushNotificationService {
constructor() {
this.loadVapidKeys();
// Configure web-push with VAPID details
if (this.vapidKeys) {
webpush.setVapidDetails(
queueConfig.push.vapidEmail,
this.vapidKeys.publicKey,
this.vapidKeys.privateKey
);
}
}
/**
@@ -107,25 +117,37 @@ class PushNotificationService {
* Send notification to specific subscription
*/
private async sendToSubscription(subscription: PushSubscription, data: any): Promise<void> {
// In production, use web-push library:
// import webpush from 'web-push';
//
// webpush.setVapidDetails(
// 'mailto:your-email@example.com',
// this.vapidKeys.publicKey,
// this.vapidKeys.privateKey
// );
//
// return webpush.sendNotification(subscription, JSON.stringify(data));
// For development, we'll log the notification
console.log(`[PushService] Would send push notification:`, {
endpoint: subscription.endpoint,
data: data
});
// Simulate network delay
await new Promise(resolve => setTimeout(resolve, 100));
try {
const payload = JSON.stringify(data);
await webpush.sendNotification(
{
endpoint: subscription.endpoint,
keys: {
p256dh: subscription.keys.p256dh,
auth: subscription.keys.auth
}
},
payload,
{
TTL: 60 * 60 * 24, // 24 hours
}
);
console.log(`[PushService] ✓ Sent notification to ${subscription.endpoint.substring(0, 50)}...`);
} catch (error) {
// Check if subscription is expired/invalid
if ((error as any).statusCode === 410) {
console.warn(`[PushService] Subscription expired: ${subscription.endpoint.substring(0, 50)}...`);
throw new Error('Subscription expired');
}
console.error('[PushService] Failed to send notification:', {
endpoint: subscription.endpoint.substring(0, 50) + '...',
error: error instanceof Error ? error.message : String(error)
});
throw error;
}
}
/**

7
src/lib/server/parser.ts
View File

@@ -2,6 +2,7 @@ import { createLLM, checkModelAvailability } from './llm';
import { zodResponseFormat } from 'openai/helpers/zod';
import { z } from 'zod';
import { RECIPE_DETECTION_PROMPT, RECIPE_EXTRACTION_PROMPT } from './prompts/recipe-extraction';
import { logError } from './utils/logger';
const RecipeSchema = z.object({
name: z.string(),
@@ -54,8 +55,7 @@ export async function detectRecipe(text: string): Promise<boolean> {
return detectionResult.includes('yes');
} catch (e) {
console.error('[LLM] Recipe detection error:', e);
console.error('[LLM] Stack trace:', (e as Error).stack);
logError('[LLM] Recipe detection error', e);
// Check if this is a model-related error
const errorMessage = (e as Error).message || '';
@@ -112,8 +112,7 @@ export async function parseRecipe(text: string): Promise<Recipe> {
return recipe;
} catch (e) {
console.error('[LLM] Recipe parsing error:', e);
console.error('[LLM] Stack trace:', (e as Error).stack);
logError('[LLM] Recipe parsing error', e);
// Check if this is a model-related error
const errorMessage = (e as Error).message || '';

3
src/lib/server/queue/QueueManager.ts
View File

@@ -11,6 +11,7 @@
import { v4 as uuidv4 } from 'uuid';
import { tandoorConfig } from '$lib/server/tandoor-config';
import { logError } from '../utils/logger';
import type { QueueItem, QueueItemStatus, QueueStatusUpdate, QueueUpdateCallback } from './types';
/**
@@ -427,7 +428,7 @@ export class QueueManager {
try {
callback(update);
} catch (err) {
console.error('[QueueManager] Subscriber error:', err);
logError('[QueueManager] Subscriber error', err);
}
}
}

5
src/lib/server/queue/QueueProcessor.ts
View File

@@ -17,6 +17,7 @@ import { extractRecipe } from '$lib/server/parser';
import { uploadRecipeWithIngredientsDTO, uploadRecipeImage } from '$lib/server/tandoor';
import { pushNotificationService } from '$lib/server/notifications/PushNotificationService';
import { queueConfig } from './config';
import { logError } from '../utils/logger';
import type { ProgressEvent } from '$lib/server/extraction';
import type { QueueItem } from './types';
@@ -168,7 +169,7 @@ export class QueueProcessor {
const errorMsg = error instanceof Error ? error.message : 'Unknown error';
const recoverable = this.isRecoverableError(error);
console.error(`[QueueProcessor] ${recoverable ? 'Unhealthy' : 'Error'}: ${item.id}`, errorMsg);
logError(`[QueueProcessor] ${recoverable ? 'Unhealthy' : 'Error'}: ${item.id}`, error);
queueManager.updateStatus(item.id, recoverable ? 'unhealthy' : 'error', {
error: {
@@ -429,7 +430,7 @@ export class QueueProcessor {
console.warn(`[QueueProcessor] Unknown status for push notification: ${status}`);
}
} catch (error) {
console.error(`[QueueProcessor] Failed to send push notification:`, error);
logError('[QueueProcessor] Failed to send push notification', error);
// Don't let notification failures break processing
}
}

4
src/lib/server/queue/config.ts
View File

@@ -11,6 +11,7 @@ import { env } from '$env/dynamic/private';
* - TANDOOR_SERVER_URL: Base URL for Tandoor server
* - VAPID_PUBLIC_KEY: Public VAPID key for web push notifications
* - VAPID_PRIVATE_KEY: Private VAPID key for web push notifications
* - VAPID_EMAIL: Contact email for web push notifications (mailto: URI scheme)
*/
export const queueConfig = {
/** Number of items to process concurrently (default: 2) */
@@ -29,6 +30,7 @@ export const queueConfig = {
/** Web Push notification settings */
push: {
vapidPublicKey: env.VAPID_PUBLIC_KEY || 'BNextdcB_fQ0BVvyGioM5L8Tf9vKQjs-WnF-rUbnU8MdWIZQYfggIHxBnW21I-lq_0HykLCdMpYj8d5joavWdxQ',
vapidPrivateKey: env.VAPID_PRIVATE_KEY || 'JwxI_KcsBcehYcTOufMcbVWJjCq1QbH5FJmSyQuG680'
vapidPrivateKey: env.VAPID_PRIVATE_KEY || 'JwxI_KcsBcehYcTOufMcbVWJjCq1QbH5FJmSyQuG680',
vapidEmail: env.VAPID_EMAIL || 'mailto:admin@example.com'
}
};

7
src/lib/server/scheduler.ts
View File

@@ -2,6 +2,7 @@ import fs from 'fs';
import path from 'path';
import { getBrowser } from './browser';
import { env } from '$env/dynamic/private';
import { logError } from './utils/logger';
export interface SchedulerConfig {
enabled: boolean;
@@ -9,7 +10,7 @@ export interface SchedulerConfig {
}
interface SchedulerState {
intervalId: NodeJS.Timer | null;
intervalId: NodeJS.Timeout | null;
lastRenewalTime: number | null;
isRenewing: boolean;
}
@@ -98,7 +99,7 @@ async function renewInstagramAuth(): Promise<boolean> {
await page.waitForSelector('svg[aria-label="Home"]', { timeout: 30000 });
console.log('[Scheduler] Successfully authenticated with Instagram');
} catch (e) {
console.warn('[Scheduler] Home icon not found - session may be expired or invalid');
logError('[Scheduler] Home icon not found - session may be expired or invalid', e);
return false;
}
@@ -119,7 +120,7 @@ async function renewInstagramAuth(): Promise<boolean> {
return true;
} catch (error) {
console.error('[Scheduler] Instagram authentication renewal failed:', error);
logError('[Scheduler] Instagram authentication renewal failed', error);
return false;
} finally {
if (page) {

13
src/lib/server/tandoor.ts
View File

@@ -1,5 +1,6 @@
import { tandoorConfig } from '$lib/server/tandoor-config';
import { z } from 'zod';
import { logError } from './utils/logger';
/**
* Tandoor Recipe Export Format
* Based on the Default/JSON-LD Tandoor export format
@@ -132,7 +133,7 @@ async function fetchFromTandoor<T>(
if (!response.ok) {
const errorBody = await response.json().catch(() => ({}));
console.error(`API Error ${response.status}: ${response.statusText}`, errorBody);
logError(`[Tandoor] API Error ${response.status}: ${response.statusText}`, errorBody);
return {
ok: false,
error: `API Error: ${response.statusText} - ${JSON.stringify(errorBody)}`
@@ -144,7 +145,7 @@ async function fetchFromTandoor<T>(
return { ok: true, data };
} catch (error) {
const errorMsg = error instanceof Error ? error.message : 'Unknown error';
console.error(`Fetch error: ${errorMsg}`);
logError('[Tandoor] Fetch error', error);
return {
ok: false,
error: `Fetch error: ${errorMsg}`
@@ -323,7 +324,7 @@ export async function uploadRecipeWithIngredientsDTO(
};
} catch (error) {
const errorMsg = error instanceof Error ? error.message : 'Unknown error';
console.error(`Error uploading recipe to Tandoor: ${errorMsg}`);
logError('[Tandoor] Error uploading recipe', error);
return {
success: false,
error: `Error uploading to Tandoor: ${errorMsg}`
@@ -492,11 +493,7 @@ export async function uploadRecipeImage(
return { success: true };
} catch (error) {
const errorMsg = error instanceof Error ? error.message : 'Unknown error';
const errorStack = error instanceof Error ? error.stack : '';
console.error(`[Tandoor Upload] Exception: ${errorMsg}`);
if (errorStack) {
console.error(`[Tandoor Upload] Stack: ${errorStack}`);
}
logError('[Tandoor Upload] Exception', error);
// Don't fail recipe creation if image fails
return { success: false, error: errorMsg };
}

124
src/lib/server/utils/logger.ts Normal file
View File

@@ -0,0 +1,124 @@
/**
* Logging Utilities
*
* Provides error serialization and structured logging utilities to prevent
* [object Object] logs in production. All functions handle circular references
* and properly serialize Error objects with their properties.
*
* Features:
* - Error serialization with stack traces
* - Circular reference detection and handling
* - Convenient logging wrappers
* - TypeScript-safe error handling
*/
/**
* Serializes an error object to a JSON string.
* Handles both Error instances and plain objects.
*
* @param error - Error object or unknown value to serialize
* @returns JSON string representation of the error
*
* @example
* ```typescript
* const err = new Error('Something went wrong');
* const serialized = serializeError(err);
* // Returns: '{"name": "Error", "message": "Something went wrong", "stack": "..."}'
* ```
*/
export function serializeError(error: unknown): string {
if (error instanceof Error) {
const errorObject: Record<string, any> = {
name: error.name,
message: error.message,
stack: error.stack
};
// Add custom properties from the error object
for (const key of Object.keys(error)) {
if (!(key in errorObject)) {
errorObject[key] = (error as any)[key];
}
}
return JSON.stringify(errorObject, null, 2);
}
return JSON.stringify(error, null, 2);
}
/**
* Serializes an object to a JSON string with circular reference handling.
* Prevents "Converting circular structure to JSON" errors.
*
* @param obj - Object to serialize
* @param maxDepth - Maximum depth for nested objects (default: 10)
* @returns JSON string representation of the object
*
* @example
* ```typescript
* const circular: any = { a: 1 };
* circular.self = circular;
* const serialized = serializeObject(circular);
* // Returns: '{"a": 1, "self": "[Circular]"}'
* ```
*/
export function serializeObject(obj: unknown, maxDepth: number = 10): string {
const seen = new WeakSet();
const replacer = (key: string, value: any): any => {
if (typeof value === 'object' && value !== null) {
if (seen.has(value)) {
return '[Circular]';
}
seen.add(value);
}
return value;
};
return JSON.stringify(obj, replacer, 2);
}
/**
* Logs an error to console.error with proper serialization.
* Convenience wrapper around serializeError().
*
* @param prefix - Log prefix (e.g., '[ComponentName]')
* @param error - Error object or unknown value to log
*
* @example
* ```typescript
* try {
* // ... some operation
* } catch (error) {
* logError('[QueueProcessor]', error);
* }
* ```
*/
export function logError(prefix: string, error: unknown): void {
if (error instanceof Error) {
console.error(prefix, error.message);
if (error.stack) {
console.error('Stack:', error.stack);
}
} else {
console.error(prefix, serializeError(error));
}
}
/**
* Logs an object to console.log with proper serialization.
* Handles circular references automatically.
*
* @param prefix - Log prefix (e.g., '[ComponentName]')
* @param obj - Object to log
*
* @example
* ```typescript
* const config = { url: 'https://example.com', timeout: 5000 };
* logObject('[Config]', config);
* ```
*/
export function logObject(prefix: string, obj: unknown): void {
console.log(prefix, serializeObject(obj));
}