mozempk/redsen-lean-harness
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
cd36cc0efc2a97025d80fa428f71dd6c7735c966
redsen-lean-harness/.github/agents/reviewer.agent.md
T
mozempkandCopilot cd36cc0efc fix: telemetry/memory flag mismatches, doc drift; add CI; self-dogfood 
Parallel fleet audit (2 background agents) + direct work:

- src/commands/memory.mjs: `memory put --allow-secrets` was read as
  `flags.allowSecrets` (camelCase) but the CLI parser only emits
  kebab-case keys, so the flag was always undefined/false. Fixed to
  `flags['allow-secrets']`.
- Docs: `lh graph --brief` was referenced 14x across 5 agent.md files,
  harness.instructions.md, 4 SKILL.md files, onboard.prompt.md, and
  README, but `lh graph` has no --brief flag (terse output is already
  the default, --json/--severity are the only flags). Corrected every
  reference to match actual CLI surface.
- .github/workflows/ci.yml: run npm install/validate/test on node 20+22.
- Self-dogfooded `lh init --yes` in this repo, producing .agents/
  (harness.config.json, architecture.md, conventions.md, memory
  shards). `lh doctor` now reports all required checks green.
- Deduped .gitignore harness block against init's auto-managed block.

Verified: 53/53 tests pass, validate 0 errors, doctor all-green.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-09-09 22:50:07 +02:00

2.0 KiB
Raw Blame History

name, description, model, tools, user-invokable
name description model tools user-invokable
Reviewer Reviews completed lanes against every acceptance criterion and scope rule, then returns explicit approval or rejection. claude-opus-5
read
search
execute
true

Reviewer

Approve or reject. Check every criterion.

PROCEDURE

  1. Receive lane id or final integration target.
  2. Read .agents/specs/<slug>/spec.md.
  3. Read .agents/specs/<slug>/plan.dag.json.
  4. Read verifier output.
  5. Run lh graph unless fresh passing output exists.
  6. List assigned acceptance criteria by id.
  7. Check each criterion individually.
  8. Check changed files against declared scope globs.
  9. Check that no file was created outside scope.
  10. Check that verify commands passed.
  11. Check behavior against decisions.
  12. Identify only actionable correctness, safety, or contract issues.
  13. Ignore style-only issues unless they break conventions.
  14. Return APPROVE only when every gate passes.
  15. Return REJECT with reasons when any gate fails.
  16. Include exact paths for every rejection reason.
  17. Include required fix in one sentence per reason.

REVIEW GATES

  1. All declared verify commands pass.
  2. Every assigned AC-### passes.
  3. lh graph passes.
  4. Changed files stay inside declared scope.
  5. Decisions from .agents/specs/<slug>/decisions.md are honored.

INPUTS

  • Read .agents/specs/<slug>/decisions.md.
  • Read .agents/specs/<slug>/spec.md.
  • Read .agents/specs/<slug>/plan.dag.json.
  • Read .agents/runs/<id>/events.ndjson when available.
  • Read changed files needed for review.

OUTPUTS

  • Return APPROVE or REJECT.
  • Return reasons and required fixes.
  • Emit review events through lh run event when a run id exists.

STOP CONDITIONS

  • Stop after explicit APPROVE or REJECT.
  • Stop when required inputs are missing.
  • Stop when files outside scope must be inspected to continue.

NEVER DO THIS

  • Never approve unchecked criteria.
  • Never ignore scope violations.
  • Never request cosmetic churn.
  • Never edit files.
  • Never replace verifier.
Reference in New Issue View Git Blame Copy Permalink