feat(SCOPONE-0010): vendor agent assets and clean docs
This commit is contained in:
@@ -1,41 +1,41 @@
|
||||
# Findings
|
||||
|
||||
> Last Updated: 2026-04-10T09:39:37.000Z
|
||||
> Last Updated: 2026-04-10T20:33:00.000Z
|
||||
|
||||
## Summary
|
||||
|
||||
Initializer refresh for SCOPONE-0010. The cache was invalid because `docs/FINDINGS.md` no longer matched its recorded hash and still contained an outdated note about a `SettingsScene` placeholder in `main.ts`. The observations below reflect the current repository state; `docs/ARCHITECTURE.md` and `docs/CODE_STYLE.md` were revalidated unchanged against the live source.
|
||||
Documentation refresh for the current repository state. `docs/ARCHITECTURE.md` and `docs/FINDINGS.md` were updated to remove stale workflow-specific notes and now reflect the live source tree directly. `docs/CODE_STYLE.md` remains valid without changes.
|
||||
|
||||
## Codebase Observations
|
||||
|
||||
- Primary gameplay code currently lives in 15 TypeScript source files under `src/`; the Android wrapper adds 3 Java files.
|
||||
- Primary gameplay code currently lives in 17 TypeScript source files under `src/`; the Android wrapper adds 3 Java files under `android/app/src/`.
|
||||
- The project is structurally split between framework-free gameplay modules in `src/game/` and Phaser scene code in `src/scenes/`.
|
||||
- `src/scenes/GameScene.ts` and `src/game/ai.ts` remain the two largest concentrations of application logic.
|
||||
- A dedicated audio preference path now exists: `src/game/preferences.ts`, `src/scenes/MenuScene.ts`, and `src/scenes/SettingsScene.ts`.
|
||||
- `main.ts` now imports and registers `SettingsScene` directly in the Phaser scene list; the earlier placeholder-scene workaround is no longer present.
|
||||
- A dedicated audio preference seam exists in `src/game/preferences.ts`, and it is consumed from both `MenuScene` and `SettingsScene`.
|
||||
- `main.ts` imports and registers `SettingsScene` directly in the Phaser scene list.
|
||||
- The AI transport layer is a stable three-file path: `ai-worker-protocol.ts`, `ai-worker-client.ts`, and `ai.worker.ts`.
|
||||
- The AI exposes three difficulty levels: `beginner`, `advanced`, and `master`.
|
||||
- `advanced` and `master` both use `CardTracker` to reason about unseen cards without directly reading hidden hands.
|
||||
- The base `master` search profile is `4300 ms / 8 samples / depth 5 / batch 2`, with tighter endgame branches down to `3200 ms / 4 samples / exact remaining depth / batch 1` when 4 cards remain.
|
||||
- `GameScene` consumes AI progress callbacks to update an on-screen think bar while a worker request is running.
|
||||
- `GameScene` now enforces `AI_MIN_THINK_MS = 1000` and `MOVE_OUTCOME_STATUS_MS = 2000` through timer-backed scene logic.
|
||||
- `GameScene` enforces `AI_MIN_THINK_MS = 1000` and `MOVE_OUTCOME_STATUS_MS = 2000` through timer-backed scene logic.
|
||||
- `AIWorkerClient` fails over pending work to in-thread `chooseMove()` if worker creation, posting, or deserialization fails.
|
||||
- `MenuScene` now includes a responsive layout path for compact viewports, driven by calculated panel bounds and camera zoom instead of a fixed desktop-only composition.
|
||||
- The AI benchmark harness is now in source under `src/game/ai-benchmark.ts` and `src/game/ai-benchmark-fixtures.ts`, and `package.json` exposes it as `npm run benchmark:ai-quality`.
|
||||
- `MenuScene` includes a compact-viewport layout path driven by calculated panel bounds and camera zoom.
|
||||
- The AI benchmark harness lives in source under `src/game/ai-benchmark.ts` and `src/game/ai-benchmark-fixtures.ts`, and `package.json` exposes it as `npm run benchmark:ai-quality`.
|
||||
- The current benchmark contract is iteration 5: 13 fixed fixtures, 6 critical concepts, and 48 self-play matches.
|
||||
- The Android wrapper targets SDK 36 with `minSdkVersion` 24 and applies immersive mode from the native activity.
|
||||
- Audio remains procedural via Web Audio; there is still no dedicated audio asset pipeline in the source tree.
|
||||
- No ESLint or Prettier configuration is present.
|
||||
- The only repository-wide verification command supplied is `npx tsc --noEmit`.
|
||||
- Audio remains procedural via Web Audio; no dedicated audio asset pipeline was discovered in the source tree.
|
||||
- No ESLint or Prettier configuration was discovered.
|
||||
- No top-level `tests/` directory was discovered during analysis.
|
||||
|
||||
## Potential Improvement Areas
|
||||
|
||||
- `GameScene.ts` still centralizes layout, turn flow, HUD updates, effects, audio, status messaging, and AI orchestration in one scene class.
|
||||
- `ai.ts` still combines heuristic tiers, inference helpers, determinization, move ordering, and alpha-beta evaluation in one module.
|
||||
- `MenuScene.ts` now carries substantial responsive layout and decorative rendering logic in the same scene that handles navigation and difficulty selection.
|
||||
- `MenuScene.ts` carries responsive layout and decorative rendering logic in the same scene that handles navigation and difficulty selection.
|
||||
- Worker transport is isolated cleanly, but progress rendering and fallback behavior remain coupled to scene-level UI concerns.
|
||||
- A 3.2 to 4.35 second master search window may still be noticeable on slower mobile devices even with yielding and the minimum-think pacing already in place.
|
||||
- There is no dedicated automated rules test suite beyond type-checking and the AI benchmark harness.
|
||||
- A 3.2 to 4.3 second master search window may still be noticeable on slower mobile devices even with yielding and minimum-think pacing already in place.
|
||||
- No dedicated automated rules test suite was discovered beyond type checking and the AI benchmark harness.
|
||||
- Formatting and style are enforced socially rather than by automated linting or formatting tools.
|
||||
|
||||
## Current Rule / Implementation Notes
|
||||
@@ -54,7 +54,7 @@ Initializer refresh for SCOPONE-0010. The cache was invalid because `docs/FINDIN
|
||||
- `advanced` adds race awareness, anti-scopa logic, partner setup, denari pressure, and tracker-based probability estimates.
|
||||
- `master` orders legal moves with a quick evaluator, samples hidden hands, and scores them with alpha-beta search under a dynamic deadline.
|
||||
- Progress is reported through `AIDecisionProgress` so the scene can keep the think bar responsive.
|
||||
- `CardTracker` now exposes same-rank residue summaries through `getValueRankResidue()` and `getValueRankResidueSummary()`, and those semantics are the live inference surface for unseen-value reasoning.
|
||||
- `CardTracker` remains the inference surface for unseen-card reasoning across higher difficulties.
|
||||
|
||||
### Worker execution snapshot
|
||||
|
||||
@@ -68,7 +68,7 @@ Initializer refresh for SCOPONE-0010. The cache was invalid because `docs/FINDIN
|
||||
|
||||
- `BootScene` loads atlas assets and presents a simple loading bar.
|
||||
- `main.ts` registers `BootScene`, `MenuScene`, `GameScene`, and `SettingsScene` directly in the Phaser game config.
|
||||
- `MenuScene` now exposes both difficulty selection and a dedicated entry point into `SettingsScene`, with a separate compact-layout branch for smaller viewports.
|
||||
- `MenuScene` exposes both difficulty selection and a dedicated entry point into `SettingsScene`, with a separate compact-layout branch for smaller viewports.
|
||||
- `SettingsScene` persists music and effects toggles immediately through `saveAudioPreferences()`.
|
||||
- `GameScene` reads normalized audio preferences from scene data or persisted storage before match start.
|
||||
- `GameScene` tracks played and captured cards in `CardTracker` as the round evolves.
|
||||
@@ -77,9 +77,9 @@ Initializer refresh for SCOPONE-0010. The cache was invalid because `docs/FINDIN
|
||||
|
||||
### Benchmark snapshot
|
||||
|
||||
- `ai-benchmark.ts` now uses a simulated timing source for fixture and self-play evaluation instead of depending only on wall-clock timing.
|
||||
- `ai-benchmark.ts` uses a simulated timing source for fixture and self-play evaluation rather than only wall-clock timing.
|
||||
- The benchmark summary records per-seed aggregates, dual-loss seeds, and a regression watchlist intersection.
|
||||
- The harness remains source-local under `src/`, so it is covered by the default `npx tsc --noEmit` include set.
|
||||
- The harness remains source-local under `src/`, so it is covered by the default TypeScript include set.
|
||||
|
||||
## Research Performed
|
||||
|
||||
@@ -137,16 +137,9 @@ Initializer refresh for SCOPONE-0010. The cache was invalid because `docs/FINDIN
|
||||
|
||||
### SCOPONE-0010: UI, settings, and benchmark refresh notes (2026-04-09)
|
||||
|
||||
- `src/game/preferences.ts` is now the authoritative audio preference seam. It normalizes stored values and shields scenes from malformed storage state.
|
||||
- `src/scenes/MenuScene.ts` now reads persisted audio preferences and exposes a dedicated settings entry point instead of keeping audio options implicit.
|
||||
- `src/game/preferences.ts` is the authoritative audio preference seam. It normalizes stored values and shields scenes from malformed storage state.
|
||||
- `src/scenes/MenuScene.ts` reads persisted audio preferences and exposes a dedicated settings entry point.
|
||||
- `src/scenes/SettingsScene.ts` exists as a real scene and persists music and effects toggles independently through `saveAudioPreferences()`.
|
||||
- `src/scenes/GameScene.ts` already contains the previously planned pacing and status work: `AI_MIN_THINK_MS = 1000`, `MOVE_OUTCOME_STATUS_MS = 2000`, timer-backed `setStatus(...)`, and `handleSceneShutdown()` timer cleanup are all present in source and should be treated as current behavior, not future work.
|
||||
- `src/game/ai-benchmark.ts` now enforces an iteration 5 contract with simulated timing, cross-seed aggregation, dual-loss reporting, and a regression watchlist intersection. Older findings that described iteration 4 targets or wall-clock-only timing are stale.
|
||||
- `src/main.ts` now imports and registers `SettingsScene` directly; the earlier placeholder-scene note is no longer accurate.
|
||||
|
||||
### SCOPONE-0010: Phaser scene-manager and resize notes (2026-04-10)
|
||||
|
||||
- Source: Context7 `/websites/phaser_io_api-documentation`, queries `Phaser 3.87 ScenePlugin add remove get duplicate key behavior and Scale Manager resize event for responsive UI layout in scenes` and `Phaser 3.87 SceneManager add scene duplicate key error getScene get key existing scene unique key documentation`.
|
||||
- `SceneManager.add(key, ...)` requires a unique scene key; replacing a scene under the same key should remove the existing scene first rather than attempting a duplicate add.
|
||||
- `SceneManager.remove(key)` clears the scene key from the cache and destroys that scene's systems, so the current `MenuScene.ensureSettingsSceneAvailable()` pattern is intentionally destructive when it replaces the placeholder scene.
|
||||
- Phaser's resize path dispatches resize events from the Scale Manager / renderer when the display changes size, which is the framework-supported hook for responsive scene relayout if this iteration introduces viewport-aware menu composition.
|
||||
- `src/scenes/GameScene.ts` contains the current pacing and status behavior: `AI_MIN_THINK_MS = 1000`, `MOVE_OUTCOME_STATUS_MS = 2000`, timer-backed status updates, and shutdown cleanup.
|
||||
- `src/game/ai-benchmark.ts` enforces an iteration 5 contract with simulated timing, cross-seed aggregation, dual-loss reporting, and a regression watchlist intersection.
|
||||
- `src/main.ts` imports and registers `SettingsScene` directly.
|
||||
|
||||
Reference in New Issue
Block a user