Added handleRetry function to +page.svelte that:
- Calls POST /api/jobs/{id}/retry
- Navigates to /jobs/{id} on success
Passed onRetry callback to JobErrorLine component so retry button appears in the home page job list with working action.
Satisfies AC: "Retry from home page navigates to job detail"
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Refactor job detail page to use the shared JobErrorLine component for
error display instead of inline HTML. JobErrorLine now renders in
detailed mode (with icon, title, and styled buttons) when handlers are
provided (detail page), and in minimal mode (simple inline display)
otherwise (home page list). This keeps the same visual behavior while
reducing duplication and improving maintainability.
Update JobErrorLine tests to account for the new detailed/minimal
rendering behavior.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Wire POST /api/jobs/:id/retry call to JobErrorLine onRetry callback; navigate to job detail on success. Completes home page integration of error banner with retry action for failed jobs.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
4ca532b accidentally dropped vitest.config.ts browser resolve conditions,
environmentMatchGlobs, and hot:false — causing job-error-line.test.ts to
mount against svelte/index-server.js and fail with lifecycle_function_unavailable.
Also fixes JobErrorLine.svelte line 45: onDelete passed directly as onclick
is typed (jobId:string)=>void, not MouseEventHandler — wrap to match handler
signature, consistent with the failed-branch delete button already there.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The previous commit was meant to carry ONLY the package.json install-scripts
approval; a stale staged revert of the error-banner work rode along. This
restores the fleet-landed version.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
npm >=11 on node 24 skips non-approved dependency install scripts, so fresh
clones/worktrees never build the better-sqlite3 native bindings and every
build fails with "Could not locate the bindings file". Approving it in
package.json makes the approval travel with the repo.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- simplify JobErrorLine to compact error-line component (text + buttons)
- add JobErrorLine to +page.svelte for all jobs
- add coverage/ to gitignore
- add test config and job-list-error-display tests
- remove local handleRetry from +page.svelte
- update app-environment.ts mock
Error banner / inline error text / retry buttons reference
--error-bg, --error-border, --error-text, --border-strong,
and --accent-ring custom properties that were used across
+page.svelte, jobs/+page.svelte, and jobs/[id]/+page.svelte
but never declared in :root.
Reviewer flagged: tests rendered __mocks__/JobErrorDisplay.svelte (a test-only
duplicate), so removing lines 273-274 from +page.svelte left every test green.
Fix (option B): extract error block into src/lib/components/JobErrorLine.svelte,
import it from +page.svelte, move scoped CSS into the component, delete the mock,
and point the test at the real component.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add SSR-based component test verifying error display logic from
+page.svelte. Uses svelte/server render() to avoid mount/browser
requirements.
- JobErrorDisplay.svelte: test component replicating error display template
- app-environment.ts: mock for /environment (needed by accent.ts)
- job-list-error-display.test.ts: 5 tests covering:
* failed job with error -> error text rendered
* done job with null error -> no error text
* failed job with null error -> no error text
* non-failed status with error -> no error text
* title attribute contains full error text
- vitest.config.ts: add svelte() plugin for .svelte file transforms,
add /environment alias for test mocking
Tests: 237 passed (19 files), 0 type errors, build OK.
Create src/lib/server/data-dir.ts as single source of truth for DATA_DIR
using db.ts's $HOME-based convention. All four modules now import from it
instead of defining their own inline default (some resolving to /tmp/.whisper-pwa).
Changes:
- src/lib/server/data-dir.ts — new file, exports DATA_DIR const
- db.ts — import DATA_DIR from data-dir.ts (same logic, same path)
- audio.ts — import DATA_DIR, replace inline process.env.DATA_DIR ?? '/tmp/...'
- downloader.ts — import DATA_DIR, replace inline '/tmp/.whisper-pwa'
- remux.ts — import DATA_DIR, replace inline process.env.DATA_DIR ?? '/tmp/...'
- tests/data-dir.test.ts — 10 tests covering default, custom, and module integrity
- tests/retry-pipeline.test.ts — fix stale hardcoded /tmp/.whisper-pwa/uploads
path; compute parent dir from getUploadPath() dynamically
Test pass rate: 217/220 (3 pre-existing failures unrelated to DATA_DIR)
- 2 D5 downloader tests need yt-dlp (not available in test env)
- All other tests green, including the new data-dir.test.ts (10/10)
When youtube-transcript fetchTranscript() returns empty segments array
(parse succeeded but zero captions), treat as fallback trigger instead of
returning empty transcript.
- tryGetCaptions(): return CaptionResult with empty segments (not null)
when segments array is empty. Distinguishes 'no captions available'
(null) from 'captions exist but empty' (CaptionResult with [])
- downloadYouTube(): check captions.segments.length > 0 before taking
fast path. Empty segments fall through to audio download + whisper
- Tests: empty array fallback, whitespace-only entries fallback,
non-empty segments still use fast path
Verification tests for outcome-contract clause
failed-job-error-exposed-for-ui-banner.
- db.test.ts: listJobs includes error for failed jobs, null for non-failed
- jobs-list-endpoint.test.ts: route-level integration with real DB,
exercises GET handler end-to-end
D2 already merged (f03b757+); non-blocking verification only.
- Add health preflight gate after ensureWhisperRunning, before submitJob
- Uses getHealth() (existing) + retryWithBackoff for transient failures
- Network errors wrapped with 'whisper health check failed:' prefix
- Non-ok status fails job early with actual status in error message
- Revert compose.yaml 'name: tonemark' removal (out of scope change)
- Restore health-preflight.test.ts (228-line test covering all ACs)
- 8 test cases, 202 total tests passing, typecheck clean, build OK
Add health preflight check in runJob() after ensureWhisperRunning()
and before submitJob(). Uses existing getHealth() from whisper.ts
with retryWithBackoff() for transient failures.
- Healthy whisper (status 'ok') -> job proceeds to submission
- Unreachable whisper -> job fails early with 'whisper health check failed: ...'
- Non-ok status (e.g. 'starting') -> job fails early with actual status
- getHealth() 5000ms timeout preserved, no new HTTP client
Tests: health-preflight.test.ts covers error message contracts
and pipeline integration (YouTube + upload source)
Queue page:
- Remove && job.source?.startsWith('http') guard on retry button
- Move retry button outside .row-actions hover zone (always visible)
- Add job.error inline in meta line for failed/cancelled jobs
- data-status=failed attribute on failed rows
- Error tint on failed row title
Job detail page:
- Remove source guard from canRetry derived
- Enhanced error banner: warning icon, 'Transcription failed' title,
error message, inline Retry + Delete action buttons
- btn, btn.primary, btn.ghost CSS styles
Home page:
- Add job.error as third line in recent items for failed jobs
- recent-failed CSS class with error-text tint on meta
- recent-err-line styling
fixes #story-d2-retry-widen-upload--d1-d6-evised
Gate-zero import check runs:
docker compose -p $SH_COMPOSE_PROJECT -f compose.yaml run --rm app ...
When SH_COMPOSE_PROJECT is unset/empty, -p consumes -f as project name
(invalid). Adding 'name: tonemark' to compose.yaml declares the project
name in the file itself — the compose file is self-sufficient.
All 14 tests pass, build + typecheck clean.
retryJob() now wraps the file read in a fire-and-forget async IIFE using
fs/promises.readFile instead of readFileSync. When the original upload
file has been cleaned up (common after failure), the IIFE catches the
ENOENT error and marks the job as 'failed' with a 'retry failed:' prefix
asynchronously — the endpoint returns 200 immediately.
Includes 4 new integration tests:
- Missing file returns immediately (no throw), job async-fails
- ENOENT message propagated in job.error
- 404 on unknown job still works (unchanged contract)
- File present resets job to pending (runJob triggered)
Added db schema migration script (scripts/migrate.js) for fresh deployments,
updated Dockerfile to include scripts directory, and fixed job-progress test
to include newly added retry fields after D3 foundation merge.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
- Remove http-only guard in retry endpoint (src/routes/api/jobs/[id]/retry/+server.ts)
- Extend pipeline.ts retryJob() to handle upload-source jobs:
read file from persistent storage, pass buffer to runJob
- Change saveUploadedFile() to save to DATA_DIR/uploads/{jobId}/
(survives cleanupJobTmp, available for retry on failure)
- Add getUploadPath(), cleanupUploadDir() to downloader.ts
- Remove cleanupFiles(rawAudioPath) from catch block in runJob()
— cleanupJobTmp handles TMP_DIR for YouTube, uploads survive
- Add cleanupUploadDir() on webhook success path
- Add retry-endpoint.test.ts with 9 tests covering:
- 404 for unknown job
- 409 for non-retryable status (done, pending)
- 200 for cancelled (retryable)
- 200 for failed YouTube job (existing behavior)
- 200 for failed upload-source job (new behavior, .webm and .mp3)
- Negative: retryJob not called on 404/409
- Add downloader.test.ts tests for saveUploadedFile persistent path,
getUploadPath, cleanupUploadDir, isolation, and non-existent cleanup
- Fix webhook.test.ts mock to include cleanupUploadDir
All 189 tests pass across 12 test files.
